Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix add index on timestamp column bug #7812

Merged
merged 3 commits into from
Oct 10, 2018

Conversation

crazycs520
Copy link
Contributor

cherry-pick from #7724

@crazycs520
Copy link
Contributor Author

/run-all-tests

1 similar comment
@crazycs520
Copy link
Contributor Author

/run-all-tests

@winkyao
Copy link
Contributor

winkyao commented Oct 8, 2018

@crazycs520 You should run all-test by /run-all-tests tikv=release-2.0 tidb-test=release-2.0 in cherry-pick pr.

@winkyao
Copy link
Contributor

winkyao commented Oct 8, 2018

/run-all-tests tikv=release-2.0 tidb-test=release-2.0

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor Author

/run-common-test tikv=release-2.0 tidb-test=release-2.0

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackysp
Copy link
Member

jackysp commented Oct 8, 2018

/run-common-test tikv=release-2.0 tidb-test=release-2.0

Copy link
Contributor

@ciscoxll ciscoxll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ciscoxll
ciscoxll previously approved these changes Oct 9, 2018
@crazycs520
Copy link
Contributor Author

/run-common-test tikv=release-2.0 tidb-test=release-2.0

@crazycs520
Copy link
Contributor Author

/run-all-tests tikv=release-2.0 tidb-test=release-2.0

@crazycs520
Copy link
Contributor Author

/run-all-tests tikv=release-2.0 tidb-test=release-2.0

@zimulala zimulala merged commit 173a792 into pingcap:release-2.0 Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants