stats: fix combined index low-bound check #7814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
lysu
changed the title
alivxxx
reviewed
Sep 29, 2018
statistics/histogram.go
Outdated
|
|
||
| } | ||
|
|
||
| func (hg *Histogram) canCMSketch(val types.Datum, partialCover bool) bool { |
There was a problem hiding this comment.
I feel it is a little awkward: why histogram needs to care about cm sketch? Maybe a better solution is to have different outOfRange for Column and Index.
shenli
reviewed
Sep 29, 2018
util/chunk/compare.go
Outdated
| } | ||
|
|
||
| // CompareOpt compares the value with ad with prefixAsEq optional | ||
| func CompareOpt(row Row, colIdx int, ad *types.Datum, prefixAsEq bool) int { |
There was a problem hiding this comment.
Please add comments for prefixAsEq.
There was a problem hiding this comment.
emmm..this param is stranger, I tried to refactor it
|
/run-all-tests |
crazycs520
added
status/LGT2
alivxxx
approved these changes
Oct 8, 2018
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fixes #7813
=1will failure in low-bound check and break, so can not do following cm-sketch logic.What is changed and how it works?
for range
(kid1, pid2) ~ (kid2,pid2), judgekid1as hit in range.Check List
Tests
Code changes
Side effects
Related changes
This change is