Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: only rebase auto increment ID when needed (cherry-pick) #7846

Merged
merged 2 commits into from
Oct 9, 2018

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Oct 9, 2018

What problem does this PR solve?

Cherry-pick #7515 to release-2.0 to slow down the auto ID increasing speed.

What is changed and how it works?

Rebase auto ID when needed.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • Increased code complexity

Related changes

PTAL @winkyao @lamxTyler

@jackysp
Copy link
Member Author

jackysp commented Oct 9, 2018

/run-all-tests tikv=release-2.0 tidb-test=release-2.0

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 9, 2018
@winkyao winkyao merged commit 0e01dbe into pingcap:release-2.0 Oct 9, 2018
@jackysp jackysp deleted the cp-autoid branch October 9, 2018 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants