Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain: fix stats updating bug when no stats worker (#7864) #7871

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Oct 11, 2018

What problem does this PR solve?

Cherry pick #7864.

What is changed and how it works?

In addition to the memory leak problem, this also fixes that bug that cannot get analyze result after the stats worker panics (But if the worker panics during the analyze, it still cannot get the result).

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • None

@alivxxx alivxxx changed the title domain: fix stats updating bug when no stats woker (#7864) domain: fix stats updating bug when no stats worker (#7864) Oct 11, 2018
@zz-jason
Copy link
Member

LGTM

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 11, 2018
@alivxxx
Copy link
Contributor Author

alivxxx commented Oct 11, 2018

/run-all-tests tikv=release-2.0 tidb-test=release-2.0

@ngaut ngaut merged commit 44cb05f into pingcap:release-2.0 Oct 11, 2018
@alivxxx alivxxx deleted the stats-bug branch October 11, 2018 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants