Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: just print error message when ddl job is normal to cancel, to eliminate noisy log #7875

Merged
merged 2 commits into from
Oct 18, 2018
Merged

ddl: just print error message when ddl job is normal to cancel, to eliminate noisy log #7875

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
feaf5de
ddl: just print error message when ddl job is normal to calcel, to el…
winkyao Oct 11, 2018
d8692e6
Merge branch 'master' into clear_ddl_log
ngaut Oct 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ddl/ddl_worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ func (w *worker) runDDLJob(d *ddlCtx, t *meta.Meta, job *model.Job) (ver int64,
if job.State != model.JobStateCancelled {
log.Errorf("[ddl-%s] run DDL job err %v", w, errors.ErrorStack(err))
} else {
log.Infof("[ddl-%s] the DDL job is normal to cancel because %v", w, errors.ErrorStack(err))
log.Infof("[ddl-%s] the DDL job is normal to cancel because %v", w, err)
}

job.Error = toTError(err)
Expand Down