-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix reassigned partition id in truncate table
does not take effect
#7919
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
45bf86b
fix reassigned partition id in truncate table does not take effect
ciscoxll 2fa6b5d
Address comment
ciscoxll 09b6b23
Address comment
ciscoxll ff5da6b
Address comment
ciscoxll 50de52c
Merge branch 'master' into truncate-table-improve
ciscoxll 63c4cd0
Merge branch 'master' into truncate-table-improve
ciscoxll File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -417,3 +417,24 @@ func isRangePartitionColUnsignedBigint(cols []*table.Column, pi *model.Partition | |
} | ||
return false | ||
} | ||
|
||
// truncateTableFromReassignPartitionIDs reassign a new partition ids. | ||
func truncateTableFromReassignPartitionIDs(job *model.Job, t *meta.Meta, tblInfo *model.TableInfo) error { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
newDefs := make([]model.PartitionDefinition, 0, len(tblInfo.Partition.Definitions)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no need to define a new defs slice. for i := range tblInfo.Partition.Definitions {
var pid int64
pid, err = t.GenGlobalID()
if err != nil {
job.State = model.JobStateCancelled
return ver, errors.Trace(err)
}
tblInfo.Partition.Definitions[i].ID = pid
} |
||
for _, def := range tblInfo.Partition.Definitions { | ||
pid, err := t.GenGlobalID() | ||
if err != nil { | ||
job.State = model.JobStateCancelled | ||
return errors.Trace(err) | ||
} | ||
newDef := model.PartitionDefinition{ | ||
ID: pid, | ||
Name: def.Name, | ||
LessThan: def.LessThan, | ||
Comment: def.Comment, | ||
} | ||
newDefs = append(newDefs, newDef) | ||
} | ||
tblInfo.Partition.Definitions = newDefs | ||
return nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
truncateTableFromReassignPartitionIDs
--->truncateTableByReassignPartitionIDs