Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stats: fix histogram boundaries overflow error (#7883) #7944

Merged
merged 1 commit into from
Oct 18, 2018
Merged

stats: fix histogram boundaries overflow error (#7883) #7944

merged 1 commit into from
Oct 18, 2018

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Oct 18, 2018

What problem does this PR solve?

Cherry pick #7883

What is changed and how it works?

Cherry pick #7883

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • None

@alivxxx
Copy link
Contributor Author

alivxxx commented Oct 18, 2018

/run-all-tests

@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 18, 2018
@zz-jason
Copy link
Member

@winoros @XuHuaiyu PTAL

winoros
winoros approved these changes Oct 18, 2018
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

XuHuaiyu
XuHuaiyu approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 18, 2018
@zz-jason zz-jason merged commit 4021862 into pingcap:release-2.1 Oct 18, 2018
@alivxxx alivxxx deleted the boudaries-overflow branch October 18, 2018 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
component/statistics status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alivxxx @zz-jason @winoros @XuHuaiyu