-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chunk: [experimental] new wide chunk in prealloc way #7967
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
It seems that CI has failed. Please confirm. |
lysu
commented
Oct 22, 2018
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
experimental new wide chunk in prealloc way, inspired by #7916
pprof wide table query under dead loop will find
newFixedColumn
and itsmake([]T, y, z)
will be called many times and use many time, and it's also let GC into badWhat is changed and how it works?
so this PR want to deduce
newFixedColumn
andmakeslice
by prealloc a pre-calucated memory arena, then direct use them if column number is big.WIP for run-all-tests and real-world's performance.
Check List
Tests
add bench two way to New 45 columns chunk.
Code changes
Side effects
Related changes
This change is