-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: enable range typed table partition #8011
Conversation
/run-all-tests |
/run-integration-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So there is no way to disable the range partition. I prefer to change the flag of enable-partition true by default.
After a partitioned table is created, turn off the flag is to late: So this feature is controlled by the data, rather than by the code, provide a flag can't help. |
For some POCs, the customers could rebuild the cluster and continue the POC test if they could disable the partition feature. Otherwise, the test may be blocked. @tiancaiamao |
executor/show.go
Outdated
@@ -620,6 +620,7 @@ func (e *ShowExec) fetchShowCreateTable() error { | |||
if partitionInfo != nil { | |||
// this if statement takes care of range columns case | |||
if partitionInfo.Columns != nil && partitionInfo.Type == model.PartitionTypeRange { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Any idea about the error? @zimulala |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Enable range typed table partition by default.
What is changed and how it works?
If the SQL is
create table ... partition by range ...
,the
PartitionInfo.Enable
field will be set to trueSo this kind of table partition is handled.
Check List
Tests
Side effects
If a user create a range typed table partition with this TiDB binary, he can't degrade to an old version.
@shenli @ciscoxll