Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix a panic of a cached prepared statement with IndexScan(#8017) #8055

Merged
merged 2 commits into from
Oct 25, 2018
Merged

planner: fix a panic of a cached prepared statement with IndexScan(#8017) #8055

merged 2 commits into from
Oct 25, 2018

Conversation

dbjoa
Copy link
Contributor

@dbjoa dbjoa commented Oct 25, 2018

What problem does this PR solve?
Cherry-pick #8017 to release 2.1

PTAL @zz-jason, @winoros

@sre-bot
Copy link
Contributor

sre-bot commented Oct 25, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. sig/planner SIG: Planner type/2.1 cherry-pick labels Oct 25, 2018
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dbjoa
Copy link
Contributor Author

dbjoa commented Oct 25, 2018

/run-all-tests

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 25, 2018
@tiancaiamao
Copy link
Contributor

/run-all-tests tidb-test=release-2.1

@tiancaiamao
Copy link
Contributor

/run-common-test tidb-test=release-2.1

2 similar comments
@zz-jason
Copy link
Member

/run-common-test tidb-test=release-2.1

@dbjoa
Copy link
Contributor Author

dbjoa commented Oct 25, 2018

/run-common-test tidb-test=release-2.1

@zz-jason
Copy link
Member

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason merged commit 1b8102a into pingcap:release-2.1 Oct 25, 2018
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants