-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: refine PhysicalProjection.ResolveIndices during neighbouring Proj #8073
Conversation
PTAL @zz-jason |
@XuHuaiyu Please fill the description and add a unit test. |
00ac877
to
2c9aa76
Compare
/run-all-tests |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@XuHuaiyu Please cherrypick this bugfix to the release-2.0 and release-2.1 branch. |
Description and test to be added.
What problem does this PR solve?
Before this PR, this query will cause a panic.
What is changed and how it works?
explain info:
After buildProjection4Union,
Projection_21:test.t1.a
.Index
andProjection_21:test.t1.c
.Index
will be 0 and 1 individually.While both the two
Projection_22.test.t1.a
.Index
are 0.Thus during execution, when
Projection_21:test.t1.c
calling chunk.SwapColumn, it will get an empty chunk.column, which would cause the panic.Check List
Tests
Code changes
Side effects
Related changes
release-2.1 release-2.0