Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan: try point get when plan cache is enabled #8108

Merged
merged 5 commits into from
Oct 31, 2018
Merged

plan: try point get when plan cache is enabled #8108

merged 5 commits into from
Oct 31, 2018

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Oct 30, 2018 •
edited
Loading

What problem does this PR solve?

Fix #8095

What is changed and how it works?

Enhance rebuildRange to support updating PointGetPlan. Specifically, use parameter values to update Handle/IndexValues of PointGetPlan. DELETE/UPDATE is not cacheable yet, so it should be safe.

Check List

Tests

  • Unit test

Side effects

  • Increased code complexity

Related changes

N/A

@eurekaka eurekaka added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner status/WIP labels Oct 30, 2018
@eurekaka eurekaka changed the title plan: try point get when plan cache is enabled [WIP] plan: try point get when plan cache is enabled Oct 30, 2018
@eurekaka
Copy link
Contributor Author

/run-all-tests

@eurekaka eurekaka changed the title [WIP] plan: try point get when plan cache is enabled plan: try point get when plan cache is enabled Oct 30, 2018
zz-jason
zz-jason reviewed Oct 31, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 31, 2018
@zz-jason
Copy link
Member

@winoros @XuHuaiyu PTAL

@winoros
Copy link
Member

winoros commented Oct 31, 2018

Yeah BTW, you can paste a sysbench result with this branch.

@eurekaka
Copy link
Contributor Author

eurekaka commented Oct 31, 2018 •
edited
Loading

sysbench result using oltp_point_select.lua when plan cache is enabled:

qps
latency
improve

winoros
winoros approved these changes Oct 31, 2018
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@winoros winoros merged commit 59c4db7 into pingcap:master Oct 31, 2018
@eurekaka eurekaka deleted the point_get_plan_cache branch November 1, 2018 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eurekaka @zz-jason @winoros