-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tikvclient: Add endKey param to Scanner (#8178) #8247
Merged
zz-jason
merged 5 commits into
pingcap:release-2.1
from
MyonKeminta:misono/cherry-pick-scan-end-key
Nov 12, 2018
Merged
tikvclient: Add endKey param to Scanner (#8178) #8247
zz-jason
merged 5 commits into
pingcap:release-2.1
from
MyonKeminta:misono/cherry-pick-scan-end-key
Nov 12, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
MyonKeminta
changed the title
[Waiting for #8081] [release-2.1] cherry-pick: Fix kv_scan out of bound
[release-2.1] cherry-pick: tikvclient: Add endKey param to Scanner (#8178)
Nov 9, 2018
MyonKeminta
changed the title
[release-2.1] cherry-pick: tikvclient: Add endKey param to Scanner (#8178)
[DNM] [release-2.1] cherry-pick: tikvclient: Add endKey param to Scanner (#8178)
Nov 9, 2018
LGTM |
zz-jason
added
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
component/tikv
type/2.1 cherry-pick
status/LGT1
Indicates that a PR has LGTM 1.
labels
Nov 10, 2018
zz-jason
changed the title
[DNM] [release-2.1] cherry-pick: tikvclient: Add endKey param to Scanner (#8178)
tikvclient: Add endKey param to Scanner (#8178)
Nov 10, 2018
/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1 |
/run-integration-common-test tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1 |
winkyao
approved these changes
Nov 12, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zz-jason
added
status/LGT2
Indicates that a PR has LGTM 2.
status/all tests passed
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/tikv
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
status/LGT2
Indicates that a PR has LGTM 2.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR cherry-picks #8178 to release-2.1 branch, and needs to be merged after:
This fixes in some conditions the kv_scan goes to a deleted range, which may make tikv panic.
What is changed and how it works?
This PR cherry-picks #8178 to release-2.1 branch.
Check List
Code changes
Side effects
Related changes