-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: preparation for Go1.11 module cherry pick #8388
Conversation
…#7952) Make the ast package get rid of the dependency of types.Datum
@tiancaiamao CI failed. |
edd32af
to
6d43789
Compare
Some important notes: #8398 is reverted in this PR, you can add it back again after my work finish @jackysp In this commit https://github.com/pingcap/tidb/pull/7862/files#diff-c31b8654bc3f8f52137403cf3dc617faL571 #7842 is not in the release-2.1 branch, so the parser used by release-2.1 reset the changes @eurekaka |
/run-all-tests tidb-test=release-2.1 |
LGTM |
Great work! @tiancaiamao |
/run-common-test tidb-test=pr/657 |
1 similar comment
/run-common-test tidb-test=pr/657 |
/run-integration-ddl-test tidb-test=pr/657 |
/run-integration-common-test tidb-test=pr/657 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Preparation for cherry pick Go1.11 module to release-2.1 branch
What is changed and how it works?
Cherry pick the later three PRs is quite easy, nearly no conflict.
This one is quite difficult, I rewrite the changes from the original PR #8036
To make CI pass, release-2.1 need a special parser branch which I'll push later.
Still WIP, there are two test cases fail.This change is