-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: add check when create table with foreign key. (#7885) #8407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests tidb-test=release-2.1 pd=release-2.1 tikv=release-2.1 |
* ddl: add check when create table with foreign key
crazycs520
force-pushed
the
check-foreign-2.1
branch
from
November 22, 2018 10:41
eebf26e
to
2cb8852
Compare
/run-all-tests tidb-test=release-2.1 pd=release-2.1 tikv=release-2.1 |
zimulala
reviewed
Nov 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
zz-jason
previously approved these changes
Nov 23, 2018
zz-jason
added
status/LGT2
Indicates that a PR has LGTM 2.
status/all tests passed
labels
Nov 23, 2018
crazycs520
force-pushed
the
check-foreign-2.1
branch
from
November 23, 2018 05:00
e50a0a0
to
4b4c443
Compare
crazycs520
changed the title
ddl: check foreign key
ddl: check foreign key when create table.
Nov 23, 2018
zz-jason
changed the title
ddl: check foreign key when create table.
ddl: add check when create table with foreign key. (#7885)
Nov 23, 2018
zz-jason
approved these changes
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
cherry-pick from #7885
What is changed and how it works?
This change is