executor: privilege check USE command #8418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improves mysql compatibility
|
/run-all-tests |
|
/run-unit-test |
winkyao
reviewed
Nov 23, 2018
|
@tiancaiamao @lysu @winkyao PTAL |
zz-jason
added
status/LGT1
|
LGTM |
|
/run-all-tests |
tiancaiamao
added
status/LGT2
tiancaiamao
approved these changes
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In MySQL, a
use DBwill return a privilege error for users who would not have access to the DB irrespective on whether it exists.This PR changes TiDB to behave similarly and not leak that a schema exists.
What is changed and how it works?
The
use DB(and protocol commands that are similar) now may return an error.Check List
Tests
Code changes
Side effects
Related changes
This change is