Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core, expression: don't pushdown filters contains set or get var (#8412) #8454

Merged
merged 6 commits into from
Nov 29, 2018

Conversation

zz-jason
Copy link
Member

@zz-jason zz-jason commented Nov 26, 2018

cherry pick #8412 to release-2.0


This change is Reviewable

@zz-jason zz-jason added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/2.0 cherry-pick labels Nov 26, 2018
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 26, 2018
XuHuaiyu
XuHuaiyu previously approved these changes Nov 26, 2018
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu
Copy link
Contributor

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 26, 2018
@zz-jason
Copy link
Member Author

/run-integration-common-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0
/run-common-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zz-jason
Copy link
Member Author

weird, the test is passed in my local machine..

@zz-jason
Copy link
Member Author

/run-integration-common-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0
/run-common-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zz-jason
Copy link
Member Author

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zz-jason
Copy link
Member Author

/run-unit-test

@zz-jason zz-jason merged commit a9c77f1 into pingcap:release-2.0 Nov 29, 2018
@zz-jason zz-jason deleted the cherrypick/2.0-uservar branch November 29, 2018 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants