plan: export MockTable and MockContext to be used in cascades package
#8503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eurekaka
added
type/enhancement
|
/run-all-tests |
winoros
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #8449
What problem does this PR solve?
Unit test of cascades package need mocked table information declared in
MockTable(), but this function is in_test.gofile of core package, which would only be compiled when testing core package, so cascades package cannot reuse these codes currently.What is changed and how it works?
Move
MockTable()andMockContext()to a new filemock.goto make them usable for cascades package.Check List
Tests
Code changes
Side effects
N/A
Related changes
N/A
This change is