Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: do not build range for NullOuterVal in IndexLookUpJoin (#8505) #8507

Merged
merged 3 commits into from
Nov 29, 2018

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Nov 29, 2018

cherry-pick #8505


This change is Reviewable

@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution type/2.1 cherry-pick labels Nov 29, 2018
@XuHuaiyu
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@XuHuaiyu
Copy link
Contributor Author

PTAL @zz-jason @winoros @eurekaka

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 29, 2018
@zz-jason
Copy link
Member

/run-integration-common-test
/run-unit-test

@XuHuaiyu
Copy link
Contributor Author

/run-integration-common-test tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason merged commit def415f into pingcap:release-2.1 Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants