Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix canceling add index and add column, port from #8171 #8513

Merged
merged 6 commits into from
Dec 13, 2018
Merged

ddl: fix canceling add index and add column, port from #8171 #8513

merged 6 commits into from
Dec 13, 2018

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Nov 29, 2018

What problem does this PR solve?

This PR is ported from #8171, not cherry-pick, so please review carefully.


This change is Reviewable

@winkyao
Copy link
Contributor Author

winkyao commented Nov 30, 2018

@zimulala @crazycs520 PTAL

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@winkyao
Copy link
Contributor Author

winkyao commented Dec 6, 2018

/run-sqllogic-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed labels Dec 12, 2018
@winkyao winkyao merged commit ffc8f6c into pingcap:release-2.0 Dec 13, 2018
@winkyao winkyao deleted the cherry-pick-2.0-cancel branch December 13, 2018 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants