Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Txn() function signature refactor and remove ActivePendingTxn() (#8327) #8570

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Dec 4, 2018

What problem does this PR solve?
Cherry pick from #8327

What is changed and how it works?
I thought #8327 is just a simple refactor, so I did not cherry pick that to release 2.0

But later it turns out that without the commit, release 2.0 will fail on this test #8566

@crazycs520 @winkyao


This change is Reviewable

@tiancaiamao
Copy link
Contributor Author

/run-all-tests tidb-test=pr/673

@tiancaiamao tiancaiamao added the priority/P1 The issue has P1 priority. label Dec 4, 2018
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit ed6e8ff into pingcap:release-2.0 Dec 5, 2018
@tiancaiamao tiancaiamao deleted the cherry-2.0-fix-txn branch December 5, 2018 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P1 The issue has P1 priority. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants