Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: support system variable interactive_timeout (#8487) #8573

Merged
merged 12 commits into from
Dec 14, 2018
Merged

session: support system variable interactive_timeout (#8487) #8573

merged 12 commits into from
Dec 14, 2018

Conversation

hhu-cc
Copy link
Contributor

@hhu-cc hhu-cc commented Dec 4, 2018

What problem does this PR solve?

support system variable interactive_timeout. #8487

What is changed and how it works?

when client set Capability Flags CLIENT_INTERACTIVE, init wait_timeout with interactive_timeout

Check List

Tests

  • Integration test

Code changes

  • Has exported variable/fields change

Related changes

  • Need to be included in the release note

This change is Reviewable

@sre-bot
Copy link
Contributor

sre-bot commented Dec 4, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@hhu-cc
Copy link
Contributor Author

hhu-cc commented Dec 4, 2018

@lysu Could you help to write a integration test , please ?

@zz-jason zz-jason added contribution This PR is from a community contributor. component/server labels Dec 5, 2018
@zz-jason zz-jason changed the title [WIP]support system variable interactive_timeout (#8487) [WIP]session: support system variable interactive_timeout (#8487) Dec 5, 2018
@lysu lysu self-assigned this Dec 7, 2018
@lysu
Copy link
Contributor

lysu commented Dec 11, 2018

/run-all-tests tidb-test=pr/679

@lysu
Copy link
Contributor

lysu commented Dec 11, 2018

/run-common-test tidb-test=pr/679

@pingcap pingcap deleted a comment from jackysp Dec 11, 2018
@lysu lysu changed the title [WIP]session: support system variable interactive_timeout (#8487) session: support system variable interactive_timeout (#8487) Dec 11, 2018
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 11, 2018
@lysu lysu requested review from jackysp and tiancaiamao December 11, 2018 12:11
@lysu
Copy link
Contributor

lysu commented Dec 11, 2018

/run-all-tests tidb-test=pr/679

@lysu
Copy link
Contributor

lysu commented Dec 11, 2018

/run-common-test tidb-test=pr/679
/run-integration-common-test tidb-test=pr/679

@zhouqiang-cl
Copy link
Contributor

/run-common-test tidb-test=pr/679

@lysu
Copy link
Contributor

lysu commented Dec 12, 2018

/run-all-tests tidb-test=pr/679

@tiancaiamao
Copy link
Contributor

LGTM

@zhouqiang-cl
Copy link
Contributor

/run-common-test tidb-test=pr/679
/run-integration-common-test tidb-test=pr/679

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 13, 2018
@lysu lysu merged commit 808eab1 into pingcap:master Dec 14, 2018
glkappe added a commit to glkappe/docs-cn that referenced this pull request Aug 3, 2020
TomShawn added a commit to pingcap/docs-cn that referenced this pull request Aug 7, 2020
* 增加 interactive_timeout 描述

pingcap/tidb#8573

* Update system-variables.md

Co-authored-by: lysu <sulifx@gmail.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: lysu <sulifx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants