Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core: correct column name with unary plus sign #8702

Merged
merged 6 commits into from
Dec 19, 2018

Conversation

zyguan
Copy link
Contributor

@zyguan zyguan commented Dec 16, 2018

What problem does this PR solve?

Column names returned by tidb are inconsistent with which returned by mysql when select field contains one or more positive signs.

2018-12-16_175602

The left one showes the result returned by master and the right one is the result returned by mysql.

What is changed and how it works?

Extract inner value from UnaryOperationExpr (just like the way we handle parentheses).

Check List

Tests

  • Unit test
  • Integration test

This change is Reviewable

@zyguan
Copy link
Contributor Author

zyguan commented Dec 16, 2018

oops, it seems there are something wrong with go1.11.4.

@zz-jason zz-jason added contribution This PR is from a community contributor. sig/planner SIG: Planner labels Dec 17, 2018
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@winoros
Copy link
Member

winoros commented Dec 18, 2018

/run-all-tests

@winoros
Copy link
Member

winoros commented Dec 18, 2018

/run-unit-test

@winoros winoros added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 19, 2018
@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 19, 2018
@zimulala
Copy link
Contributor

/run-all-tests

@winoros winoros merged commit 29c17a1 into pingcap:master Dec 19, 2018
yu34po pushed a commit to yu34po/tidb that referenced this pull request Jan 2, 2019
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Apr 8, 2020

/run-cherry-picker

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 8, 2020

cherry pick to release-2.1 in PR #16149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants