-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table: check non-BMP characters and return error when the charset is utf8 and sql mode is strict mode #8738
Conversation
…utf8 and sql mode is strict mode
@kennytm PTAL |
…/tidb into check_non_bmp_characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR need to be cherry-pick to 2.1
and 2.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed 2 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
@tiancaiamao @jackysp @lysu PTAL |
@ciscoxll This PR will break backward compatibility, I will not pick it to 2.0 and I'm considering to pick it to 2.1 |
@winkyao Please add some proper labels, for example, component, type, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe tikv also need check this too @breeswish
Reviewable status: complete! all files reviewed, all discussions resolved
/run-all-tests |
…/tidb into check_non_bmp_characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
/run-all-tests |
… utf8 and sql mode is strict mode (pingcap#8738)
What problem does this PR solve?
Before this PR, TiDB don't handle the non-BMP character when the charset is utf8. Run the sqls in mysql:
But in TiDB:
What is changed and how it works?
utf8 cannot handle the Unicode character length larger than 3.
Check List
Tests
Code changes
Side effects
Related changes
This change is