Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: replace github.com/etcd-io/gofail with the forked one (#8693) #8751

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Dec 19, 2018

cherry pick from #8693 to release-2.1

@lysu @jackysp @winkyao
/cc @zhouqiang-cl


This change is Reviewable

With the adoption of Go module, GOPATH is not need any more
But github.com/etcd-io/gofail doesn't support packages outside the GOPATH
To overcome the drawback, this commit replace it with our forked one
@tiancaiamao tiancaiamao added type/2.1 cherry-pick type/enhancement The issue or PR belongs to an enhancement. labels Dec 19, 2018
@tiancaiamao
Copy link
Contributor Author

/run-all-tests tidb-test=relase-2.1

@ngaut
Copy link
Member

ngaut commented Dec 19, 2018

LGTM

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl
Copy link
Contributor

/run-all-tests tidb-test=release-2.1

@jackysp jackysp merged commit 0c7ca13 into pingcap:release-2.1 Dec 19, 2018
@tiancaiamao tiancaiamao deleted the cherry-pick-gofail branch December 19, 2018 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants