Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add the error check (#8770) #8806

Merged
merged 3 commits into from
Dec 25, 2018
Merged

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Dec 25, 2018

What problem does this PR solve?

cherry-pick #8770


This change is Reviewable

@zimulala
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 25, 2018
@lysu
Copy link
Contributor

lysu commented Dec 25, 2018

LGTM

@zimulala
Copy link
Contributor Author

PTAL @XuHuaiyu @crazycs520

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 25, 2018
@ngaut ngaut merged commit fcd6d7d into pingcap:release-2.0 Dec 25, 2018
@zimulala zimulala deleted the err-check branch December 25, 2018 11:09
tiancaiamao added a commit that referenced this pull request Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants