Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimizer: use multi-column index #887

Merged
merged 2 commits into from
Feb 2, 2016
Merged

optimizer: use multi-column index #887

merged 2 commits into from
Feb 2, 2016

Conversation

coocood
Copy link
Member

@coocood coocood commented Feb 2, 2016

fixes #859

@coocood
Copy link
Member Author

coocood commented Feb 2, 2016

@shenli @qiuyesuifeng PTAL

qiuyesuifeng
qiuyesuifeng reviewed Feb 2, 2016
View reviewed changes
optimizer/plan/refiner.go
rangePoints := fullRange
for _, cond := range p.AccessConditions {
rangePoints = rb.intersection(rangePoints, rb.build(cond))
// Build rangePoints for non-equal access condtions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conditions

@shenli
Copy link
Member

shenli commented Feb 2, 2016

LGTM

@qiuyesuifeng
Copy link
Member

LGTM

coocood added a commit that referenced this pull request Feb 2, 2016
@coocood
Merge pull request #887 from pingcap/coocood/multi-column-index
ba4e909 
optimizer: use multi-column index
@coocood coocood merged commit ba4e909 into master Feb 2, 2016
@coocood coocood deleted the coocood/multi-column-index branch February 2, 2016 07:15
rleungx pushed a commit to rleungx/tidb that referenced this pull request Mar 1, 2024
@zeminzhou @ti-chi-bot @Defined2014
[cherry-pick upstream 51227] planner: fix ExtractCorrelatedCols metho…
88e21ff 
…d in PhysicalTableScan (pingcap#887)

* planner: fix ExtractCorrelatedCols method in PhysicalTableScan  (pingcap#51205) (pingcap#51227)

close pingcap#51204

* make check

Signed-off-by: zzm <zhouzemin@pingcap.com>

* gctuner: make TestIssue48741 more stable (pingcap#49430)

---------

Signed-off-by: zzm <zhouzemin@pingcap.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Co-authored-by: Hangjie Mo <mohangjie1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't get index scan when index's columns >=3!
3 participants
@coocood @shenli @qiuyesuifeng