Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: validate value for global time_zone sys variable #8876

Merged
merged 2 commits into from
Dec 29, 2018
Merged

session: validate value for global time_zone sys variable #8876

merged 2 commits into from
Dec 29, 2018

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Dec 29, 2018 •
edited by c4pt0r
Loading

What problem does this PR solve?

Before this PR:

mysql> set global time_zone = 'timezone';
Query OK, 0 rows affected (0.01 sec)

mysql> \q
Bye
[root@localhost ~/go/src/github.com/pingcap/tidb]$ mysql -u root -P4000 -h127.0.0.1 -D test
ERROR 1298 (HY000): Unknown or incorrect time zone: 'timezone'

What is changed and how it works?

Validate value for global time_zone system variable before setting it.
After this PR:

mysql> set global time_zone = 'timezone';
ERROR 1298 (HY000): Unknown or incorrect time zone: 'timezone'

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

N/A

Related changes

  • Need to cherry-pick to the release branch

This change is Reviewable

@eurekaka eurekaka added type/bugfix This PR fixes a bug. component/session labels Dec 29, 2018
zz-jason
zz-jason reviewed Dec 29, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

zz-jason commented Dec 29, 2018 •
edited
Loading

@XuHuaiyu, @qw4990 PTAL

XuHuaiyu
XuHuaiyu approved these changes Dec 29, 2018
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu
Copy link
Contributor

/run-all-tests

@XuHuaiyu XuHuaiyu added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 29, 2018
@lysu lysu merged commit 164747c into pingcap:master Dec 29, 2018
@eurekaka eurekaka deleted the timezone_check branch December 29, 2018 07:58
eurekaka added a commit to eurekaka/tidb that referenced this pull request Dec 29, 2018
@eurekaka
session: validate value for global time_zone sys variable (pingcap#8876)
f672356
@eurekaka eurekaka mentioned this pull request Dec 29, 2018
Merged
zz-jason pushed a commit that referenced this pull request Dec 29, 2018
@eurekaka @zz-jason
session: validate value for global time_zone sys variable (#8876) (#8879
8ee7459 
)
yu34po pushed a commit to yu34po/tidb that referenced this pull request Jan 2, 2019
@eurekaka @yu34po
session: validate value for global time_zone sys variable (pingcap#8876)
82be7b7
crazycs520 added a commit to crazycs520/tidb that referenced this pull request Feb 21, 2019
@crazycs520
sessionctx, executor: Add correctness check when set system variables (…
5fcd802 
…pingcap#7117) (pingcap#8876)
@crazycs520 crazycs520 mentioned this pull request Feb 21, 2019
Merged
zz-jason pushed a commit that referenced this pull request Feb 22, 2019
@crazycs520 @zz-jason
sessionctx/variable: Add correctness check when set system variables (#…
08cde60 
…7117), (#8876) (#9413)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
component/session status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eurekaka @zz-jason @XuHuaiyu @lysu