Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/ranger: fix incorrect behavior about index who has prefix column(#8851) #8878

Merged
merged 3 commits into from
Dec 29, 2018

Conversation

winoros
Copy link
Member

@winoros winoros commented Dec 29, 2018

What problem does this PR solve?

cherry-pick the fix #8851 to master branch.

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Increased code complexity

Related changes

  • Need to be included in the release note fix the range information built from index who has prefix column, it may cause tikv panic in a very rare situation

This change is Reviewable

@winoros winoros added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Dec 29, 2018
@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 29, 2018
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 29, 2018
@alivxxx
Copy link
Contributor

alivxxx commented Dec 29, 2018

/run-all-tests

@zz-jason zz-jason merged commit 9b0eb88 into pingcap:master Dec 29, 2018
@winoros winoros deleted the ranger-fix-cherry-pick-master branch January 2, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants