Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: update generated column inside a transaction should return error (#8909) #8980

Merged

Conversation

zz-jason
Copy link
Member

@zz-jason zz-jason commented Jan 8, 2019

cherry pick #8909 to release-2.1

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member Author

zz-jason commented Jan 8, 2019

/run-all-tests tidb-test=release-2.1 pd-release-2.1 tikv=release-2.1

@eurekaka
Copy link
Contributor

eurekaka commented Jan 8, 2019

@zz-jason CI failed, PTAL

@zz-jason
Copy link
Member Author

zz-jason commented Jan 9, 2019

@eurekaka CI is fixed. PTAL, thanks

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 9, 2019
@eurekaka
Copy link
Contributor

eurekaka commented Jan 9, 2019

/run-all-tests tidb-test=release-2.1 pd-release-2.1 tikv=release-2.1

@zz-jason zz-jason merged commit 2691a41 into pingcap:release-2.1 Jan 9, 2019
@zz-jason zz-jason deleted the cherrpick/2.1-update-gene-col-txn branch January 9, 2019 03:20
@zz-jason
Copy link
Member Author

zz-jason commented Jan 9, 2019

😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants