dev row constructor #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -557,6 +558,7 @@ sys_var "@@"(({global}".")|({session}".")|{local}".")?{ident} | |||
| {right} return right | |||
| {rollback} lval.item = string(l.val) | |||
| return rollback | |||
| {row} return row | |||
There was a problem hiding this comment.
row is an unreserved keyword. Please treat is as other unreserved keyword, like "rollback".
And also update the test case in parser_test.go.
|
PTAL |
| // CheckOneColumn checks whether expression e has only one column for the evaluation result. | ||
| // Now most of the expressions have one column except Row expression. | ||
| func CheckOneColumn(e expression.Expression) error { | ||
| _, ok := e.(*Row) |
There was a problem hiding this comment.
Not need to check if len(e.values) == 1?
Or why not rename this function to "IsRowExpr" and return bool?
There was a problem hiding this comment.
no need, row(1) is valid.
because later we may check subselect expression, not only row.
There was a problem hiding this comment.
row(1) will be parsed failed in parser
|
PTAL @shenli |
|
LGTM |
| if err != nil { | ||
| return | ||
| } | ||
|
|
||
| return Val == nil != is.Not, nil | ||
| return val == nil != is.Not, nil |
There was a problem hiding this comment.
should this line split into two lines？
There was a problem hiding this comment.
maybe we just need a parenthesis
|
LGTM |
1 similar comment
|
LGTM |
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
* *: added support for storing checkpoint at local filesystem * config, tests: change default checkpoint driver to "file" * mydump: regenerate the parser to avoid golang/go#27350 during coverage * checkpoints: addressed comments
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
okJiang
pushed a commit
to okJiang/tidb
that referenced
this pull request
Oct 19, 2021
iosmanthus
pushed a commit
to iosmanthus/tidb
that referenced
this pull request
Oct 31, 2022
Signed-off-by: disksing <i@disksing.com> Signed-off-by: disksing <i@disksing.com> Co-authored-by: ystaticy <y_static_y@sina.com>
mittalrishabh
pushed a commit
to mittalrishabh/tidb
that referenced
this pull request
May 30, 2024
close pingcap#53037 Co-authored-by: Michael Deng <33045922+michaelmdeng@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base support row constructor like
select row(1, 1) > row(1,1)row constructor now only supports in comparison operation.
TODO in other PRs:
select row(1, 1)is not allowed.