Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: reset hasMatch flag for each outer row in merge join #9046

Merged
merged 3 commits into from
Jan 14, 2019

Conversation

eurekaka
Copy link
Contributor

What problem does this PR solve?

Fix #9044

What is changed and how it works?

Reset hasMatch flag for each outer row in merge join executor.

Check List

Tests

  • Unit test

Code changes

N/A

Side effects

N/A

Related changes

  • Need to cherry-pick to the release branch

@eurekaka eurekaka added type/bugfix This PR fixes a bug. sig/execution SIG execution labels Jan 14, 2019
@eurekaka
Copy link
Contributor Author

/run-all-tests

@codecov-io
Copy link

codecov-io commented Jan 14, 2019

Codecov Report

Merging #9046 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9046      +/-   ##
==========================================
+ Coverage   67.25%   67.26%   +<.01%     
==========================================
  Files         371      371              
  Lines       76194    76195       +1     
==========================================
+ Hits        51248    51255       +7     
+ Misses      20412    20409       -3     
+ Partials     4534     4531       -3
Impacted Files Coverage Δ
executor/merge_join.go 81.6% <100%> (+0.1%) ⬆️
util/systimemon/systime_mon.go 80% <0%> (-20%) ⬇️
expression/schema.go 94.11% <0%> (-0.85%) ⬇️
store/tikv/lock_resolver.go 42.65% <0%> (+0.94%) ⬆️
ddl/delete_range.go 78.85% <0%> (+4.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c98f69...9a54bf1. Read the comment docs.

executor/merge_join.go Outdated Show resolved Hide resolved
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka
Copy link
Contributor Author

/run-all-tests

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 14, 2019
@eurekaka
Copy link
Contributor Author

/run-unit-test

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 14, 2019
@zz-jason zz-jason merged commit 463d44c into pingcap:master Jan 14, 2019
@zz-jason
Copy link
Member

@eurekaka Please cherry pick it to release-2.1 and release-2.0 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants