Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: throw "too big precision" error for CAST(AS TIME) (#8907) #9058

Merged
merged 3 commits into from
Jan 15, 2019
Merged

expression: throw "too big precision" error for CAST(AS TIME) (#8907) #9058

merged 3 commits into from
Jan 15, 2019

Conversation

zz-jason
Copy link
Member

cherrypick #8907 to release 2.1

@zz-jason zz-jason added sig/planner SIG: Planner type/2.1 cherry-pick type/bugfix This PR fixes a bug. labels Jan 15, 2019
@zz-jason
Copy link
Member Author

/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

@zz-jason zz-jason requested review from eurekaka and XuHuaiyu January 15, 2019 03:39
XuHuaiyu
XuHuaiyu reviewed Jan 15, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member Author

/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. status/all tests passed labels Jan 15, 2019
@zz-jason zz-jason requested review from winoros and alivxxx January 15, 2019 05:32
alivxxx
alivxxx approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 15, 2019
@zz-jason zz-jason merged commit 8780814 into pingcap:release-2.1 Jan 15, 2019
@zz-jason zz-jason deleted the cherrpick/2.1-cast-as-time branch January 15, 2019 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@alivxxx alivxxx alivxxx approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zz-jason @XuHuaiyu @alivxxx