-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: improve syntax error code & message compatibility #9103
Conversation
/run-all-tests tidb-test=pr/723 |
/run-common-test tidb-test=pr/723 |
/run-all-tests tidb-test=pr/723 |
/run-unit-test tidb-test=pr/723 |
/run-all-tests tidb-test=pr/723 |
/run-unit-test tidb-test=pr/723 |
1 similar comment
/run-unit-test tidb-test=pr/723 |
/run-unit-test tidb-test=pr/723 |
/run-all-tests tidb-test=pr/723 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-common-test tidb-test=pr/723 |
@tiancaiamao PTAL |
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #9103 +/- ##
==========================================
- Coverage 67.21% 67.21% -0.01%
==========================================
Files 371 371
Lines 76933 76942 +9
==========================================
+ Hits 51714 51718 +4
- Misses 20602 20608 +6
+ Partials 4617 4616 -1
Continue to review full report at Codecov.
|
@tiancaiamao It seems like this PR has broken Integration Test:
|
What problem does this PR solve?
ref pingcap/parser#175
and pre-append user-friendly error message, and use right error code.
What is changed and how it works?
SyntaxError
,SyntaxWarn
convert error/warns returned by parserCheck List
Tests
Code changes
Side effects
Related changes
This change is