Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: handle Float32 for builtin function Values() (#9215) #9223

Merged
merged 1 commit into from
Jan 30, 2019
Merged

expression: handle Float32 for builtin function Values() (#9215) #9223

merged 1 commit into from
Jan 30, 2019

Conversation

zz-jason
Copy link
Member

cherry pick #9215 to release 2.1

@zz-jason
Copy link
Member Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zhouqiang-cl
Copy link
Contributor

/run-unit-test

@zz-jason zz-jason requested review from XuHuaiyu and eurekaka January 30, 2019 04:55
XuHuaiyu
XuHuaiyu reviewed Jan 30, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eurekaka
eurekaka approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed labels Jan 30, 2019
@zz-jason zz-jason merged commit 82f8d55 into pingcap:release-2.1 Jan 30, 2019
@zz-jason zz-jason deleted the cherrpick/2.1-values-float32 branch January 30, 2019 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@eurekaka eurekaka eurekaka approved these changes

Assignees
No one assigned
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zz-jason @zhouqiang-cl @eurekaka @XuHuaiyu