Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: handle empty input and improve compatibility for format (#8797) #9235

Merged
merged 1 commit into from
Feb 1, 2019
Merged

expression: handle empty input and improve compatibility for format (#8797) #9235

merged 1 commit into from
Feb 1, 2019

Conversation

zz-jason
Copy link
Member

cherry pick #8797 to release 2.1

@zz-jason
Copy link
Member Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

zimulala
zimulala reviewed Feb 1, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 1, 2019
eurekaka
eurekaka approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 1, 2019
@zz-jason zz-jason merged commit 5fed205 into pingcap:release-2.1 Feb 1, 2019
@zz-jason zz-jason deleted the cherrpick/2.1-kenan-format branch February 1, 2019 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@eurekaka eurekaka eurekaka approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zz-jason @zimulala @eurekaka