-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner/core: refine explain for window function #9270
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9270 +/- ##
==========================================
- Coverage 67.22% 67.22% -0.01%
==========================================
Files 371 371
Lines 77303 77353 +50
==========================================
+ Hits 51968 51997 +29
- Misses 20692 20714 +22
+ Partials 4643 4642 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some unit test for coverage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/run-all-tests |
What problem does this PR solve?
Display partition by, order by and frame info for window function in explain.
Fix #8835
What is changed and how it works?
Format partition by, order by and frame info in explain.
Check List
Tests
Code changes
Side effects
Related changes