Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core: refine explain for window function #9270

Merged
merged 4 commits into from
Feb 13, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Feb 11, 2019

What problem does this PR solve?

Display partition by, order by and frame info for window function in explain.
Fix #8835

What is changed and how it works?

Format partition by, order by and frame info in explain.

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • None

@alivxxx alivxxx added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner labels Feb 11, 2019
@codecov-io
Copy link

codecov-io commented Feb 11, 2019

Codecov Report

Merging #9270 into master will decrease coverage by <.01%.
The diff coverage is 42.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9270      +/-   ##
==========================================
- Coverage   67.22%   67.22%   -0.01%     
==========================================
  Files         371      371              
  Lines       77303    77353      +50     
==========================================
+ Hits        51968    51997      +29     
- Misses      20692    20714      +22     
+ Partials     4643     4642       -1
Impacted Files Coverage Δ
planner/core/physical_plans.go 60.86% <ø> (ø) ⬆️
planner/core/stringer.go 93.44% <100%> (ø) ⬆️
planner/core/exhaust_physical_plans.go 94.08% <100%> (ø) ⬆️
planner/core/explain.go 46.66% <40%> (-1.07%) ⬇️
store/tikv/scan.go 73.94% <0%> (-3.37%) ⬇️
executor/join.go 77.86% <0%> (-0.53%) ⬇️
executor/executor.go 67.31% <0%> (+0.27%) ⬆️
executor/distsql.go 73% <0%> (+0.46%) ⬆️
store/tikv/lock_resolver.go 42.65% <0%> (+0.94%) ⬆️
infoschema/infoschema.go 77.63% <0%> (+1.31%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba68605...f1190b6. Read the comment docs.

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 12, 2019
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some unit test for coverage?

@alivxxx alivxxx requested a review from winoros February 13, 2019 06:56
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alivxxx
Copy link
Contributor Author

alivxxx commented Feb 13, 2019

/run-all-tests

@alivxxx alivxxx merged commit 18ff4f9 into pingcap:master Feb 13, 2019
@alivxxx alivxxx deleted the explain branch February 13, 2019 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants