Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: handle ENUM in builtin function Values() (#9225) #9281

Merged
merged 4 commits into from
Feb 13, 2019
Merged

expression: handle ENUM in builtin function Values() (#9225) #9281

merged 4 commits into from
Feb 13, 2019

Conversation

zz-jason
Copy link
Member

cherry pick #9225 to release 2.0

@zz-jason zz-jason requested review from eurekaka and alivxxx February 12, 2019 03:56
zimulala
zimulala reviewed Feb 12, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 12, 2019
@jackysp
Copy link
Member

jackysp commented Feb 12, 2019

Please fix CI.

@zz-jason
Copy link
Member Author

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zz-jason
Copy link
Member Author

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zz-jason zz-jason requested a review from winoros February 13, 2019 11:53
winoros
winoros approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zz-jason zz-jason merged commit 1e962c9 into pingcap:release-2.0 Feb 13, 2019
@zz-jason zz-jason deleted the cherrypick/2.0-values-enum branch February 13, 2019 12:01
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@winoros winoros winoros approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

@alivxxx alivxxx Awaiting requested review from alivxxx

Assignees
No one assigned
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zz-jason @jackysp @zimulala @winoros