Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: return null when cast to huge binary type (#8768) #9350

Merged
merged 2 commits into from
Feb 19, 2019
Merged

expression: return null when cast to huge binary type (#8768) #9350

merged 2 commits into from
Feb 19, 2019

Conversation

eurekaka
Copy link
Contributor

cherry-pick #8768

@eurekaka eurekaka added type/enhancement The issue or PR belongs to an enhancement. component/expression type/2.0 cherry-pick labels Feb 19, 2019
@eurekaka
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

zimulala
zimulala reviewed Feb 19, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 19, 2019
@eurekaka eurekaka requested review from alivxxx and winoros February 19, 2019 03:32
jackysp
jackysp approved these changes Feb 19, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit a4113cd into pingcap:release-2.0 Feb 19, 2019
@eurekaka eurekaka deleted the cast_binary_20 branch February 19, 2019 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@jackysp jackysp jackysp approved these changes

@alivxxx alivxxx Awaiting requested review from alivxxx

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
component/expression status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eurekaka @zimulala @jackysp