Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: refactor constant folding for IF&IFNULL (#9094) #9351

Merged

Conversation

zz-jason
Copy link
Member

cherry pick #9094 to release-2.1

@zz-jason
Copy link
Member Author

/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 19, 2019
@zz-jason zz-jason merged commit 3ebd27b into pingcap:release-2.1 Feb 19, 2019
@zz-jason zz-jason deleted the cherrypick/2.1-constant-folding-ifnull branch February 19, 2019 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants