-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control the number of rows in chunks returned by LimitExec #9354
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9354 +/- ##
==========================================
+ Coverage 67.05% 67.07% +0.02%
==========================================
Files 372 372
Lines 78043 78053 +10
==========================================
+ Hits 52332 52357 +25
+ Misses 21033 21023 -10
+ Partials 4678 4673 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PTAL~ @lysu |
/run-all-tests |
f67e3e5
to
3cc5837
Compare
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Control the number of rows in chunks returned by
LimitExec
.Following up #9293, this PR is a subtask of #9166.
What is changed and how it works?
adjustRequiredRows
intoLimitExec
to adjust the required rows before each call ofchild's
Next
.requiredRowsDataSource
as mock DataSource when test.LimitExec
.Check List
Tests