Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: support row framed window functions #9358

Merged
merged 3 commits into from
Feb 21, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Feb 19, 2019

What problem does this PR solve?

Support row framed window functions.
Refer https://dev.mysql.com/doc/refman/8.0/en/window-functions-frames.html

What is changed and how it works?

  • Extract an interface to processing different kinds of windows.
  • Adapt the window executor to also support row framed windows.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • None

@alivxxx alivxxx added type/enhancement The issue or PR belongs to an enhancement. sig/execution SIG execution labels Feb 19, 2019
@codecov-io
Copy link

codecov-io commented Feb 19, 2019

Codecov Report

Merging #9358 into master will increase coverage by <.01%.
The diff coverage is 76.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9358      +/-   ##
==========================================
+ Coverage   67.16%   67.17%   +<.01%     
==========================================
  Files         373      373              
  Lines       78193    78269      +76     
==========================================
+ Hits        52521    52574      +53     
- Misses      20972    20991      +19     
- Partials     4700     4704       +4
Impacted Files Coverage Δ
executor/builder.go 83.6% <100%> (+0.3%) ⬆️
executor/window.go 68.35% <71.95%> (+1.3%) ⬆️
util/systimemon/systime_mon.go 80% <0%> (-20%) ⬇️
infoschema/infoschema.go 76.31% <0%> (-1.32%) ⬇️
expression/schema.go 93.75% <0%> (-0.79%) ⬇️
executor/distsql.go 71.78% <0%> (-0.46%) ⬇️
ddl/delete_range.go 79.36% <0%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5188a8...902f962. Read the comment docs.

executor/window.go Show resolved Hide resolved
executor/window.go Show resolved Hide resolved
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 20, 2019
@alivxxx alivxxx requested review from qw4990 and winoros February 21, 2019 03:04
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 21, 2019
@alivxxx
Copy link
Contributor Author

alivxxx commented Feb 21, 2019

/run-all-tests

@alivxxx alivxxx merged commit 042e410 into pingcap:master Feb 21, 2019
@alivxxx alivxxx deleted the row-framed branch February 21, 2019 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants