Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: merge statement buffer when BatchGetValues (#9374) #9414

Merged
merged 2 commits into from
Feb 22, 2019
Merged

*: merge statement buffer when BatchGetValues (#9374) #9414

merged 2 commits into from
Feb 22, 2019

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Feb 22, 2019

What problem does this PR solve?

Cherry-pick #9374 to release 2.1.

@jackysp jackysp added type/bugfix This PR fixes a bug. type/2.1 cherry-pick sig/transaction SIG:Transaction labels Feb 22, 2019
@jackysp
Copy link
Member Author

jackysp commented Feb 22, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 22, 2019
@tiancaiamao
Copy link
Contributor

LGTM

@jackysp jackysp removed the sig/transaction SIG:Transaction label Feb 22, 2019
zz-jason
zz-jason approved these changes Feb 22, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 22, 2019
@zimulala zimulala merged commit 108ce5b into pingcap:release-2.1 Feb 22, 2019
@jackysp jackysp deleted the merge_stmt_buf_2.1 branch April 4, 2019 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason approved these changes

@lysu lysu Awaiting requested review from lysu

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@winkyao winkyao Awaiting requested review from winkyao

@crazycs520 crazycs520 Awaiting requested review from crazycs520

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackysp @tiancaiamao @zz-jason @zimulala