Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin: fix admin check table err when add column not null, then add index on the column (#9108) #9470

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Feb 26, 2019

What problem does this PR solve?

cherry-pick #9108

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

@crazycs520 crazycs520 changed the title admin: fix admin check table err when add column not null, then add i… admin: fix admin check table err when add column not null, then add index on the column (#9108) Feb 26, 2019
@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 tidb-private-test=release-2.0 tikv=release-2.0

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@xiekeyi98 xiekeyi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 tidb-private-test=release-2.0 tikv=release-2.0

@zimulala zimulala merged commit 604b68e into pingcap:release-2.0 Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants