-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table: handling the boundary value of the timestamp type's default value #9578
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9578 +/- ##
================================================
- Coverage 77.5768% 77.5577% -0.0192%
================================================
Files 403 403
Lines 81844 81850 +6
================================================
- Hits 63492 63481 -11
- Misses 13656 13667 +11
- Partials 4696 4702 +6 |
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
REST LGTM
PTAL @crazycs520 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PTAL @winkyao |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
What problem does this PR solve?
Fix #9513
Before this PR:
After this PR, we can successfully execute
ALTER TABLE t ADD COLUMN ts timestamp DEFAULT '1970-01-01 08:00:01';
.What is changed and how it works?
Using the correct time zone when checking the default value.
Check List
Tests
Related changes