Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: improve test coverage in types/json #9697

Merged
merged 7 commits into from
Mar 18, 2019
Merged

types: improve test coverage in types/json #9697

merged 7 commits into from
Mar 18, 2019

Conversation

xiekeyi98
Copy link
Contributor

What problem does this PR solve?

Improve test coverage

What is changed and how it works?

Add more test functions.

Check List

Tests

  • Unit test
  • Integration test

@codecov
Copy link

codecov bot commented Mar 13, 2019 •
edited
Loading

Codecov Report

Merging #9697 into master will increase coverage by 0.0388%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master      #9697        +/-   ##
================================================
+ Coverage   67.1873%   67.2261%   +0.0388%     
================================================
  Files           381        381                
  Lines         79835      79835                
================================================
+ Hits          53639      53670        +31     
+ Misses        21410      21378        -32     
- Partials       4786       4787         +1

zz-jason
zz-jason reviewed Mar 14, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the original and improved coverage percentage?

@zz-jason zz-jason requested review from winkyao and qw4990 March 14, 2019 04:23
@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 14, 2019
@xiekeyi98
Copy link
Contributor Author 

xiekeyi@ubuntu:~/gopath/src/github.com/pingcap/tidb/types/json$ go test -cover
OK: 12 passed
PASS
coverage: 81.4% of statements
ok  	github.com/pingcap/tidb/types/json	0.009s
xiekeyi@ubuntu:~/gopath/src/github.com/pingcap/tidb/types/json$ git checkout testCoverInType 
切换到分支 'testCoverInType'
您的分支与上游分支 'origin/testCoverInType' 一致。
xiekeyi@ubuntu:~/gopath/src/github.com/pingcap/tidb/types/json$ go test -cover
OK: 17 passed
PASS
coverage: 84.7% of statements
ok  	github.com/pingcap/tidb/types/json	0.026s

This PR make the test coverage in types/json up 3%.

I will continue to work in this next work.

@qw4990 qw4990 changed the title types: imrpove test coverage in types/json types: improve test coverage in types/json Mar 18, 2019
qw4990
qw4990 approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 18, 2019
@xiekeyi98
Copy link
Contributor Author

/run-all-tests

@xiekeyi98
Copy link
Contributor Author

/run-all-tests

1 similar comment
@xiekeyi98
Copy link
Contributor Author

/run-all-tests

@zz-jason zz-jason merged commit 63eb329 into pingcap:master Mar 18, 2019
@xiekeyi98 xiekeyi98 deleted the testCoverInType branch March 18, 2019 07:41
@xiekeyi98 xiekeyi98 mentioned this pull request Apr 1, 2019
Merged
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@qw4990 qw4990 qw4990 approved these changes

@winkyao winkyao Awaiting requested review from winkyao

Assignees
No one assigned
Labels
component/test contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiekeyi98 @zz-jason @qw4990 @sre-bot