-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix str_to_date
func compatible issues 9773
#9819
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9819 +/- ##
================================================
+ Coverage 67.1505% 67.1579% +0.0074%
================================================
Files 381 381
Lines 80053 80056 +3
================================================
+ Hits 53756 53764 +8
+ Misses 21502 21500 -2
+ Partials 4795 4792 -3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Please add some tests to cover the bug fix.
@zz-jason Already added |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for your contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@b41sh Could you help us to cherry pick this change to release 2.1? |
ok |
What problem does this PR solve?
Fix the problem that
str_to_date
is not compatible with MySQLfix #9773
What is changed and how it works?
keep format '%H' without '%p'
Check List
Tests