-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Ignore FULLTEXT KEYs in CREATE/ALTER TABLE statements #9821
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9821 +/- ##
===============================================
+ Coverage 78.0515% 78.1195% +0.068%
===============================================
Files 405 405
Lines 82156 82014 -142
===============================================
- Hits 64124 64069 -55
+ Misses 13330 13244 -86
+ Partials 4702 4701 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@winkyao PTAL |
@kolbe please resolve conflicts |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The CI failed on what looks like an unrelated issue:
|
/run-all-tests |
/run-all-tests tidb-test=pr/772 |
@crazycs520 Please help Kolbe to fix the ci. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Fixes #3658
What is changed and how it works?
FULLTEXT KEY in CREATE TABLE and ALTER TABLE are ignored.
Check List
Tests
Tests for CREATE TABLE and ALTER TABLE added to ddl/db_integration_test.go.
Code changes
No
No
No
No
Side effects
No
No
No (except that valid MySQL syntax that used to generate an error is now accepted!)
Related changes
No
No
tidb-ansible
repositoryNo
Probably no