Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: Ignore FULLTEXT KEYs in CREATE/ALTER TABLE statements #9821

Merged
merged 18 commits into from
Apr 11, 2019

Conversation

kolbe
Copy link
Contributor

@kolbe kolbe commented Mar 20, 2019

What problem does this PR solve?

Fixes #3658

What is changed and how it works?

FULLTEXT KEY in CREATE TABLE and ALTER TABLE are ignored.

Check List

Tests

  • Integration test
    Tests for CREATE TABLE and ALTER TABLE added to ddl/db_integration_test.go.

Code changes

  • Has exported function/method change
    No
  • Has exported variable/fields change
    No
  • Has interface methods change
    No
  • Has persistent data change
    No

Side effects

  • Possible performance regression
    No
  • Increased code complexity
    No
  • Breaking backward compatibility
    No (except that valid MySQL syntax that used to generate an error is now accepted!)

Related changes

  • Need to cherry-pick to the release branch
    No
  • Need to update the documentation
    No
  • Need to update the tidb-ansible repository
    No
  • Need to be included in the release note
    Probably no

@kolbe kolbe requested a review from morgo March 20, 2019 05:49
@kolbe kolbe changed the title Kolbe fulltext Ignore FULLTEXT KEYs in CREATE/ALTER TABLE statements Mar 20, 2019
@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #9821 into master will increase coverage by 0.068%.
The diff coverage is 87.5%.

@@               Coverage Diff               @@
##             master      #9821       +/-   ##
===============================================
+ Coverage   78.0515%   78.1195%   +0.068%     
===============================================
  Files           405        405               
  Lines         82156      82014      -142     
===============================================
- Hits          64124      64069       -55     
+ Misses        13330      13244       -86     
+ Partials       4702       4701        -1

morgo
morgo previously requested changes Mar 20, 2019
ddl/db_integration_test.go Show resolved Hide resolved
@morgo morgo changed the title Ignore FULLTEXT KEYs in CREATE/ALTER TABLE statements ddl: Ignore FULLTEXT KEYs in CREATE/ALTER TABLE statements Mar 20, 2019
Copy link
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgo morgo added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 20, 2019
@morgo
Copy link
Contributor

morgo commented Mar 20, 2019

@winkyao PTAL

@morgo morgo requested a review from winkyao March 23, 2019 15:30
@morgo
Copy link
Contributor

morgo commented Mar 25, 2019

@kolbe please resolve conflicts

@kolbe
Copy link
Contributor Author

kolbe commented Mar 25, 2019

@kolbe please resolve conflicts

Done.

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgo morgo added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 2, 2019
@morgo morgo removed the status/LGT1 Indicates that a PR has LGTM 1. label Apr 2, 2019
@morgo
Copy link
Contributor

morgo commented Apr 2, 2019

The CI failed on what looks like an unrelated issue:

----------------------------------------------------------------------
FAIL: db_partition_test.go:1116: testIntegrationSuite.TestPartitionCancelAddIndex

db_partition_test.go:1156:
    c.Assert(err, NotNil)
... value = nil

@morgo
Copy link
Contributor

morgo commented Apr 2, 2019

/run-all-tests

@kolbe
Copy link
Contributor Author

kolbe commented Apr 2, 2019

/run-all-tests tidb-test=pr/772

@winkyao
Copy link
Contributor

winkyao commented Apr 3, 2019

@crazycs520 Please help Kolbe to fix the ci.

ddl/ddl.go Show resolved Hide resolved
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Apr 10, 2019
@zz-jason zz-jason merged commit ee99570 into pingcap:master Apr 11, 2019
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiDB parses FULLTEXT KEY incorrectly
7 participants