Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privilege: add drop_priv check when truncate table (#9870) #9876

Merged
merged 3 commits into from
Mar 25, 2019
Merged

privilege: add drop_priv check when truncate table (#9870) #9876

merged 3 commits into from
Mar 25, 2019

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Mar 25, 2019

What problem does this PR solve?

Cherry-pick from #9870

@winkyao
Copy link
Contributor Author

winkyao commented Mar 25, 2019

/rebuild

@winkyao winkyao added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Mar 25, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2019
@zz-jason
Copy link
Member

/run-all-tests tidb-test=release-2.1 pd=release-2.1 tikv=release-2.1

@winkyao
Copy link
Contributor Author

winkyao commented Mar 25, 2019

/run-unit-test tidb-test=release-2.1 pd=release-2.1 tikv=release-2.1

Copy link
Contributor

@xiekeyi98 xiekeyi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiekeyi98 xiekeyi98 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 25, 2019
@zz-jason zz-jason merged commit f9c995a into pingcap:release-2.1 Mar 25, 2019
@winkyao winkyao deleted the cherry-pick-2.1 branch March 25, 2019 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants