Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: introduce plugin framework (#8788) #9880

Merged
merged 1 commit into from
Mar 25, 2019
Merged

plugin: introduce plugin framework (#8788) #9880

merged 1 commit into from
Mar 25, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Mar 25, 2019

cherry-pick #8788 to 2.1

# Conflicts:
#	cmd/pluginpkg/pluginpkg.go
#	go.mod
#	go.sum

This change is Reviewable

@lysu
Copy link
Contributor Author

lysu commented Mar 25, 2019

need merge pingcap/parser#257 before this pr

# Conflicts:
#	cmd/pluginpkg/pluginpkg.go
#	go.mod
#	go.sum
@lysu
Copy link
Contributor Author

lysu commented Mar 25, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 49c5972 into pingcap:release-2.1 Mar 25, 2019
@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 25, 2019
@lysu lysu mentioned this pull request Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/plugin status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants